search

Ascension-Addons / WeakAuras

WeakAuras Backport for Ascension.gg
GNU General Public License v2.0
0 stars 5 forks source link

Added Boss Encounters load/unload functionality. #17

Open maedas opened 3 months ago

maedas commented 3 months ago

Pretty simple, modeled it on the zone trigger check.

Wasn't sure how to pass the current arg2 from the ENCOUNTER_START/END more efficiently but it's definitely good enough. Uses the existing StringCheck to allow for multiple boss names getting checked.

maedas commented 2 months ago

Had introduced a faulty behaviour, updated and reopened PR.

andrew6180 commented 2 months ago

@maedas is there a reason to not just copy the implementation of modern weakauras (or an older 7.x+ version?)

That handles both encounter names & encounter IDs.

maedas commented 2 months ago

@maedas is there a reason to not just copy the implementation of modern weakauras (or an older 7.x+ version?)

That handles both encounter names & encounter IDs.

I didn't look into the later versions and the encounter IDs seemed to differ between the different difficulties at times, so I decided to only use names for checking bosses.

Note that ENCOUNTER_START/END flags does not exist for the four horsemen encounter in Naxx on any level.

andrew6180 commented 2 months ago

Note that ENCOUNTER_START/END flags does not exist for the four horsemen encounter in Naxx on any level.

You can dm me any of these on discord and I can get them fixed.

I didn't look into the later versions and the encounter IDs seemed to differ between the different difficulties at times, so I decided to only use names for checking bosses.

This is because mechanics differ per difficulty, thus different encounter.

I just don't know having a name check like this is the best solution when we have encounter IDs, and we probably shouldn't just not use it because certain fights need to be updated to broadcast encounter events.

maedas commented 2 months ago

You can dm me any of these on discord and I can get them fixed. I appericiate the offer but all information I have is available here (there is no event flags at all, so nothing to report further). I did however bother to check them on multiple difficulties and found nothing anywhere.

The feedback is fair and can only say that I wish you the best of luck as I'm leaving the PR as is. I hope it at least sparked interest in the feature and someone might add it in the future, either in this form or something more sophisticated.