AscensionGameDev / Intersect-Engine

Intersect provides a complete game development suite for creating 2d mmorpgs with no programming experience required!
https://www.freemmorpgmaker.com/
Other
213 stars 353 forks source link

bug: instance warp to overworld via common-event on npc death #1686

Open izakt opened 1 year ago

izakt commented 1 year ago

Description

When a party of players returns from a Shared Instance -> Overworld, some party members appear to be invisible in the game client. When a player becomes invisible, you can still see damage counts and attack animations from the invisible player. However, you cannot actually target the invisible player.

shared-instance-warp-to-overworld-bug2

The player that appears invisible can still send requests to the player that has the visual bug.

Screenshot 2022-12-17 173049

It seems to be specific to warping players from an event triggered by NPC On Death event.

Steps to Reproduce

Editor setup:

  1. Create two connected maps, "testmap1" and "testmap2".
  2. Create a Common Event named "bugtest" with the following Commands: @>Warp Player to Overworld instance [Map: testmap1 X: 14 Y: 14] Screenshot 2022-12-17 173306
  3. Create an NPC named "test npc" with the following Common Events: On Death (for killer): [bugtest] On Death (for party): [bugtest] Screenshot 2022-12-17 173354
  4. In map "testmap1" create a map event named "warp to instance" with the following Commands: @>Warp Player to Shared instance [Map: testmap2 X: 14 Y: 14] Screenshot 2022-12-17 173454
  5. In map "testmap2", put the NPC "test npc" on the map. Screenshot 2022-12-17 173547

Gameplay:

  1. Enter the game with two characters, "Char A" and "Char B".
  2. Create a party between Char A and Char B.
  3. Go to the map named "testmap1" with Char A and Char B.
  4. With Char A and Char B, use the map event named "warp to instance" to warp to the shared instance.
  5. With Char A and Char B standing within party event trigger range, kill the NPC named "test npc" with Char A.
  6. When NPC "test npc" is killed, both characters will warp to the map named "testmap1" via common event named "bugtest" which was triggered by NPC Common Event "On Death".

Actual result: Char A will appear invisible on one of the two player's game clients. Expected results: Char A and Char B should be able to see each other.

Version with bug

v0.7.1.094

Last version that worked well

unknown

Affected platforms

Windows

Did you find any workaround?

If you leave the map and then reenter the map, the character that appeared invisible will appear visible again.

If you log out and then log back in, the character that appeared invisible will appear visible again.

Relevant log output

No response

Duplicate Bug Check

GarozoneISE commented 1 year ago

I have the same issue in my game-

Arufonsu commented 1 year ago

After many attempts where i was unable to reproduce this, i have to add the following notes which are important in order to reproduce the issue:

TimtyG commented 7 months ago

@izakt @Arufonsu can you try the latest build? I can not replicate this anymore.

Arufonsu commented 4 months ago

@izakt @Arufonsu can you try the latest build? I can not replicate this anymore.

Sadly, i have to inform you that as today (v0.8.0-beta.133), i'm still able to reproduce this issue:

image

This issue only happens when killing enemies that trigger common events that warps players out to the overworld. Warping out to the overworld through map events doesn't triggers this issue (even if the instance takes place in another map).

Arufonsu commented 2 weeks ago

( has anyone happened to test this with parallel events ? )