search

AschPlatform / asch-js

Asch frontend library
18 stars 15 forks source link

Fix asch-js tests #20

Closed a1300 closed 6 years ago

a1300 commented 6 years ago

Dear @sqfasd, dear @liangpeili

I would like to fix the tests for asch-js.

Could you assign this issue to me?

All the best a1300

liangpeili commented 6 years ago

Thanks! @a1300

a1300 commented 6 years ago

Dear @sqfasd , dear @liangpeili

I have failing tests because of a regression bug. the aschJS.crypto.verify(trs) is not working due to:
https://github.com/AschPlatform/asch-js/blob/8eec2de954a9ca5c9bda5ba5d7d75db2431b29ae/lib/transactions/crypto.js#L219

It should be: 

var signatureBuffer = new Buffer(transaction.signatures[0], "hex");

Can I provide a separate pull request to fix this issue?

All the best a1300

a1300 commented 6 years ago

I provided a pull request (https://github.com/AschPlatform/asch-js/pull/23) that fixes the problems with asch.crypto

a1300 commented 6 years ago

Pull request https://github.com/AschPlatform/asch-js/pull/26 closes this issue