search

AschPlatform / asch

Asch is an efficient, flexible, safe and decentralized application platform, which was initially designed to lower the barrier to entry for developers.The services provided by the Asch platform include a public chain and a set of application SDKs.
477 stars 148 forks source link

Update aschd #262

Closed bassjobsen closed 5 years ago

bassjobsen commented 6 years ago

some small improvements: 1) better response, when using the wrong (or empty) command 2) fix some ( there are maybe more ) unary operator expected errors, see also https://stackoverflow.com/questions/13617843/unary-operator-expected 3) mark private function with __, https://stackoverflow.com/questions/13797087/bash-why-double-underline-for-private-functions-why-for-bash-complet

a1300 commented 6 years ago

@bassjobsen could you resolve the possible merge conflict?

After that I will review your pull request :slightly_smiling_face: Thanks :+1:

a1300 commented 5 years ago

@bassjobsen thanks for resolving the merge conflict!

Review

1

I get the following error if I run ./aschd rebuild

Error (typo): 

./aschd: line 132: __chosenode: command not found

# and
./aschd: line 206: __chosenode: command not found

@bassjobsen please fix this. Then it is ready to merge!

a1300 commented 5 years ago

Review

Everything is ok 👍