Closed jefro108 closed 4 years ago
What quality settings are you using? I just started a download with BBC TV "Better" and "Best" I'm not getting a DASH stream. I can try to investigate more but I can't reproduce it right now.
GiA used to have logic that detected DASH and tried to convert it with ffmpeg but I removed it when get_iplayer started doing it for you.
Even though I am in the UK I use a VPN on my laptop by default to keep my connection secure. Sometimes it has trouble connecting with the BBC without getting 403 errors and ends up using a dash stream which then proceeded to be converted by ffmpeg!
I have noticed this now as well, unfortunately. All of my 'smart DNS' providers are generating 403 errors, but eventually one works and provides a DASH stream. Then it does the full conversion which kicks the processor into high gear. I can try changing the logic in GiA's local copy of get_iplayer to just do a copy when we get a DASH stream and see how it works.
OK, removing the aac_adtstoasc still produces a usable MP4 that can be played in TV.app even with a DASH download. According to the get_iplayer forums the 403 errors are happening due to a change on the BBC side and will be addressed in a get_iplayer update. Once that happens I can re-evaluate the situation and see if removing the conversion is still needed.
How about removing the libx264 as well ie changing "-c:v" "libx264" to "-c:v" "copy"?
Since the .ts file plays in QuickLook fine - so it is pretty Apple compatible before conversion! 😊
INFO: Converting to MP4 and embedding subtitles
INFO: Command: "/Applications/Get iPlayer Automator.app/Contents/MacOS/ffmpeg" "-loglevel" "fatal" "-stats" "-y" "-i" "/Volumes/media/Downloads/TV Shows/Clangers/Clangers.s03e18.Junk Planet.dash.ts" "-i" "/Volumes/media/Downloads/TV Shows/Clangers/Clangers.s03e18.Junk Planet.srt" "-c:v" "libx264" "-c:a" "copy" "-preset" "ultrafast" "-movflags" "+faststart" "-c:s" "mov_text" "-metadata:s:s:0" "language=eng" "-bsf:a" "aac_adtstoasc" "/Volumes/media/Downloads/TV Shows/Clangers/Clangers.s03e18.Junk Planet.partial.mp4"
I'm restoring back to what the base get_iplayer does, so none of that will happen now. Expect a new release soon.
Fixed in 1.17
When I tried to download https://www.bbc.co.uk/iplayer/episode/p07hbyjc/untouchable-the-rise-and-fall-of-harvey-weinstein it ended up being downloaded from a dash stream and produced a file 'Untouchable The Rise and Fall of Harvey Weinstein.dash.ts' which ffmpeg then proceded to convert rather than remux!
INFO: Command: "/Applications/Get iPlayer Automator.app/Contents/MacOS/ffmpeg" "-loglevel" "fatal" "-stats" "-y" "-i" "/Volumes/media/Downloads/TV Shows/Untouchable The Rise and Fall of Harvey Weinstein/Untouchable The Rise and Fall of Harvey Weinstein.dash.ts" "-c:v" "libx264" "-c:a" "copy" "-preset" "ultrafast" "-movflags" "+faststart" "-bsf:a" "aac_adtstoasc" "/Volumes/media/Downloads/TV Shows/Untouchable The Rise and Fall of Harvey Weinstein/Untouchable The Rise and Fall of Harvey Weinstein.partial.mp4"
Since the file already contains a H264 and MacOS will even play the file with QuickLook this doesn't seem necessary - plus it takes ages!
Surely a simple
-c:v copy
would suffice?