search

Ascoware / get-iplayer-automator

The goal of Get iPlayer Automator is to allow iTunes and your Mac to become the hub for your British Television experience regardless of where in the world you are. Currently, Get iPlayer Automator allows you to download and watch BBC and ITV shows on your Mac. Series-Link/PVR functionality ensures you will never miss your favourite shows. Programmes are fully tagged and added to iTunes automatically upon completion. It is simple and easy to use, and runs on any machine running Mac OS X 10.7 or later. And since the shows are in iTunes, it is extremely easy to transfer them to your iPod, iPhone, or Apple TV allowing you to enjoy your shows on the go or on your television.
GNU General Public License v3.0
144 stars 27 forks source link

Webpage link not working after software update #312

Closed PeteSut closed 3 years ago

PeteSut commented 3 years ago

having just updated to Version 1.21.4 (20210316001), now clicking on "use current webpage" reports "program page not found" even on bbc iplayer pages that I downloaded from 5min earlier.

LimeyGarp commented 3 years ago

Mine worked if I used Safari, but not with Chrome, running on Mojave

PeteSut commented 3 years ago

I am using OSX Catalina, 10.15.7. The feature does not work on Safari, Chrome or Firefox

skovatch commented 3 years ago

It looks like Chrome and/or Edge had some kind of internal change that reset the option "Allow Javascript from Apple Events". That's required for Get Current Webpage to work. Make sure that's set -- in Chrome, View -> Developer -> Allow Allow Javascript from Apple Events and in Edge, Tools -> Developer -> Allow Javascript from Apple Events and see if it's still broken.

PeteSut commented 3 years ago

Many thanks Skovatch That fixed it in Chrome (i'm on a Mac so can't comment on Edge)

watashi49uk commented 3 years ago

I have just updated to version 1.21.4 on an iMac running macOS 10.15.7 and I too cannot use the 'Use Current Webpage' option. I've tried using both Chrome and Safari, but the problem remains the same.

skovatch commented 3 years ago

I have just updated to version 1.21.4 on an iMac running macOS 10.15.7 and I too cannot use the 'Use Current Webpage' option. I've tried using both Chrome and Safari, but the problem remains the same.

See the above comment -- make sure Chrome allows you to execute JavaScript from AppleScript. The same is true for Safari -- check the Develop menu and see if Allow Javascript from AppleEvents and Allow Remote Automation are checked.

watashi49uk commented 3 years ago

I am having trouble finding the options to change Chrome as described, but have made the changes in Safari and changed my default browser accordingly. Despite this, the problem remains the same. I have tried re-starting the iMac and have checked the settings again in Safari, but still no joy.

skovatch commented 3 years ago

One other thing to check is whether or not Get iPlayer Automator is allowed to control Safari or Chrome via automation. In the "Security & Privacy" panel of System Preferences, click Privacy, and then scroll down to Automation. Get iPlayer Automator should show up in the list of apps that are allowed to control other apps.

watashi49uk commented 3 years ago

Yep, both Safari and Google Chrome are in the list and shown with a 'tick'. Tried again after a further reboot but still get the same "Program Page Not Found" message.

skovatch commented 3 years ago

I'll have to add some debugging so I can see where it's going wrong. What program page are you using with this feature?

watashi49uk commented 3 years ago

I've tried several, but this is the main one I was trying to access: https://www.bbc.co.uk/iplayer/episodes/m000sm37/bloodlands?seriesId=m000sm36 This is another that I tried out: https://www.bbc.co.uk/iplayer/episodes/p00yzlr0/line-of-duty?seriesId=b01k9pm3

skovatch commented 3 years ago

Aha, now it makes sense. 'Get Current Webpage' doesn't know how to parse that kind of program page. If you click on the pink button next to 'Start Watching' you'll be taken to the episode's page, which can be read by GiA.

That said, it could parse that kind of program page. It might be a new type of page that BBC added recently. In any event, I should be able to add support for it.

skovatch commented 3 years ago

This is a new issue, so I'm going to close this and track it in #315.