search

Ascoware / get-iplayer-automator

The goal of Get iPlayer Automator is to allow iTunes and your Mac to become the hub for your British Television experience regardless of where in the world you are. Currently, Get iPlayer Automator allows you to download and watch BBC and ITV shows on your Mac. Series-Link/PVR functionality ensures you will never miss your favourite shows. Programmes are fully tagged and added to iTunes automatically upon completion. It is simple and easy to use, and runs on any machine running Mac OS X 10.7 or later. And since the shows are in iTunes, it is extremely easy to transfer them to your iPod, iPhone, or Apple TV allowing you to enjoy your shows on the go or on your television.
GNU General Public License v3.0
144 stars 27 forks source link

Series Link not adding new shows #326

Open sacundai opened 3 years ago

sacundai commented 3 years ago

What steps will reproduce the problem? Be specific, and provide as much detail as possible. Hard to say, just that any new shows from the series link do not appear in the queue. I can add shows by "Use current Webpage"

What is the expected output? What do you see instead? New series linked shows added to the queue but cache updates do not add any new radio shows (from 10th Apr)

What version of GiA are you using? On what version of OS X? GiA 1.21.7 & MacOS 10.14.6

Are you using a web proxy? DNS proxy? VPN? VPS? No proxy or VPN.

What program are you attempting to download (full title, series and episode)? Provide only ONE program as an example. BBC Radio 1 Essential Mix 10th April (m000tx1w)

Please provide any additional information below. Have changed the hostname recently, could that be the issue?

skovatch commented 3 years ago

I can say for sure that it does work, because I track Escape To The Country and just got a new-to-me episode this morning. I tried adding that show to my auto-record queue and clicked "Add Available Shows To Queue" and got 4 shows. It's a weekly show and based on the previous dates were you expecting one from 9 April? Looks like it didn't air last week.

Never mind, you asked about the 10th of April. I don't see it either.

skovatch commented 3 years ago

As I type this, https://www.bbc.co.uk/programmes/b006wkfp/episodes/player does not show anything for the 10th of April in the episode list. The show's page https://www.bbc.co.uk/programmes/m000tx1w indicates it won't air until 30 April. So it hasn't aired yet, and therefore isn't being added by the PVR.

The question, though, is why is it being added to the queue. When you use "Use Current Webpage" GiA parses out the program ID and then tells get_iplayer to get info about it. The output of that reports:

firstbcast: 2021-04-30T01:00:00+01:00

which is in the future. So, I guess the bug is that GiA should check the 'firstbcast' field when fetching info about a show and skipping it if it's in the future.

sacundai commented 3 years ago

Thanks for having a look at this. Still not sure if it's my set up or a problem generally.

WilliamOfGaunt commented 3 years ago

It sounds similar to what happened with this week’s broadcast of More or Less on BBC World Service: on Friday the programme showed up in the GIA list as available but gave an unknown error. I checked the BBC Sounds listing and saw it was scheduled for Sunday, so I wasn’t surprised when the same happened yesterday. It downloaded fine this morning.

Apologies – I didn’t keep the logs because I knew it would sort itself out today. If it happens again I’ll be more helpful. I promise.

B.

From: Scott Kovatch Sent: Sunday, April 11, 2021 5:40 PM To: Ascoware/get-iplayer-automator Cc: Subscribed Subject: Re: [Ascoware/get-iplayer-automator] Series Link not adding new shows (#326)

As I type this, https://www.bbc.co.uk/programmes/b006wkfp/episodes/player does not show anything for the 10th of April in the episode list. The show's page https://www.bbc.co.uk/programmes/m000tx1w indicates it won't air until 30 April. So it hasn't aired yet, and therefore isn't being added by the PVR.

The question, though, is why is it being added to the queue. When you use "Use Current Webpage" GiA parses out the program ID and then tells get_iplayer to get info about it. The output of that reports:

`firstbcast: 2021-04-30T01:00:00+01:00

which is in the future. So, I guess the bug is that GiA should check the 'firstbcast' field when fetching info about a show and skipping it if it's in the future.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

skovatch commented 3 years ago

It sounds similar to what happened with this week’s broadcast of More or Less on BBC World Service: on Friday the programme showed up in the GIA list as available but gave an unknown error. I checked the BBC Sounds listing and saw it was scheduled for Sunday, so I wasn’t surprised when the same happened yesterday. It downloaded fine this morning. Apologies – I didn’t keep the logs because I knew it would sort itself out today. If it happens again I’ll be more helpful. I promise.

Did you add the episode manually or did Auto-Record do it? If the latter I think that's an issue in get_iplayer. But yes, it's the same basic bug -- fetching a program with an ID for a show not aired yet will cause problems.

Also, it's not a case of "don't do that, bozo" -- if the code can reasonably figure out how to avoid an error it should.

WilliamOfGaunt commented 3 years ago

Yes, it was loaded automatically from a PVR list.

B.

From: Scott Kovatch Sent: Sunday, April 11, 2021 9:36 PM To: Ascoware/get-iplayer-automator Cc: WilliamOfGaunt ; Comment Subject: Re: [Ascoware/get-iplayer-automator] Series Link not adding new shows (#326)

It sounds similar to what happened with this week’s broadcast of More or Less on BBC World Service: on Friday the programme showed up in the GIA list as available but gave an unknown error. I checked the BBC Sounds listing and saw it was scheduled for Sunday, so I wasn’t surprised when the same happened yesterday. It downloaded fine this morning. Apologies – I didn’t keep the logs because I knew it would sort itself out today. If it happens again I’ll be more helpful. I promise.

Did you add the episode manually or did Auto-Record do it? If the latter I think that's an issue in get_iplayer. But yes, it's the same basic bug -- fetching a program with an ID for a show not aired yet will cause problems.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.