search

Ascoware / get-iplayer-automator

The goal of Get iPlayer Automator is to allow iTunes and your Mac to become the hub for your British Television experience regardless of where in the world you are. Currently, Get iPlayer Automator allows you to download and watch BBC and ITV shows on your Mac. Series-Link/PVR functionality ensures you will never miss your favourite shows. Programmes are fully tagged and added to iTunes automatically upon completion. It is simple and easy to use, and runs on any machine running Mac OS X 10.7 or later. And since the shows are in iTunes, it is extremely easy to transfer them to your iPod, iPhone, or Apple TV allowing you to enjoy your shows on the go or on your television.
GNU General Public License v3.0
146 stars 26 forks source link

Q: Is it correct behaviour to still download .srt files when "embedded in video" is enabled? #358

Open ghost opened 2 years ago

ghost commented 2 years ago

What steps will reproduce the problem? Be specific, and provide as much detail as possible. Any download with "download subtitles" and "Embed Subtitles" checked

What is the expected output? What do you see instead? Embedded subtitles only (no separate .srt file)

What version of GiA are you using? On what version of OS X? 1.21.12

Are you using a web proxy? DNS proxy? VPN? VPS? No

What program are you attempting to download (full title, series and episode)? Provide only ONE program as an example. Fort Salem - s02e01

skovatch commented 2 years ago

It looks like at some point in the app's history there was an option to keep or delete the raw srt files, but I can't find it in the preferences anymore. The code is still there, so I guess it was dropped before I took over. I can look into adding it back.

hugofalkman commented 2 years ago

@skovatch Today the .srt file is deleted for ITV, but not for BBC. It doesn’t need to be a separate option, just delete the .srt file also for BBC, when embedded in video option is enabled.

ghost commented 2 years ago

thanks, guys!

hugofalkman commented 2 years ago

@skovatch Today's release 1.21.13 has a line item "subtitles: Always delete the raw subtitle files". As far as I can see, the GiA behavior is unchanged: the .srt file is deleted for ITV, but not for BBC.

skovatch commented 2 years ago

@skovatch Today's release 1.21.13 has a line item "subtitles: Always delete the raw subtitle files". As far as I can see, the GiA behavior is unchanged: the .srt file is deleted for ITV, but not for BBC.

You're right, I made a change but it was a while ago and I didn't really test it. This might be tough to fix because get_iplayer no longer prints out the path to the .srt file so I can't catch it for cleanup afterwards.

hugofalkman commented 2 years ago

@skovatch Don't know get_iplayer, but if it's GiA that sends the mp4 file to the iTunes library, the srt file is in the same folder. Btw that's true for youtube-dl as well.

ejstubbs commented 2 years ago

Although I agree it's a bit inconvenient to have unwanted srt files floating about, in my case at least I actually need both srt files and embedded subtitles. I watch videos off my NAS on a number of different devices using a variety of different streaming clients. Some of those clients can't handle embedded subtitles, and need the separate srt file. Others can only use embedded subtitles and ignore srt files. Having both available for a given programme means that I've got useful flexibility in my viewing choices. So by all means offer the option to delete the srt file, but the option not to delete should also be retained. If that option meant that srt files from ITV could also be retained then that would be a significant improvement for me, because at the moment I am restricted as to which clients I can watch ITV programmes on if I want subtitles. (And yes, I know there are ways to extract srt files from video with embedded subtitles, but it's a bit of a hit and miss process, and if the srt files are retained after downloading that wouldn't be necessary.)