search

Ascoware / get-iplayer-automator

The goal of Get iPlayer Automator is to allow iTunes and your Mac to become the hub for your British Television experience regardless of where in the world you are. Currently, Get iPlayer Automator allows you to download and watch BBC and ITV shows on your Mac. Series-Link/PVR functionality ensures you will never miss your favourite shows. Programmes are fully tagged and added to iTunes automatically upon completion. It is simple and easy to use, and runs on any machine running Mac OS X 10.7 or later. And since the shows are in iTunes, it is extremely easy to transfer them to your iPod, iPhone, or Apple TV allowing you to enjoy your shows on the go or on your television.
GNU General Public License v3.0
146 stars 26 forks source link

"Use Current Webpage" broken with episode titles containing commas #471

Closed gadgetchnnel closed 6 months ago

gadgetchnnel commented 8 months ago

What steps will reproduce the problem? Be specific, and provide as much detail as possible.

What is the expected output? What do you see instead? I'd expect to see the list of episodes with correct PIDs for each episode

Instead I see the following, with the PID column containing part of the title.

image Those episodes will then fail to download as the PIDs are invalid.

What version of GiA are you using? On what version of OS X? 1.26.0 on Sonoma 14.1.2 (23B92)

Are you using a web proxy? DNS proxy? VPN? VPS? No

What program are you attempting to download (full title, series and episode)? Provide only ONE program as an example.

We Forced a Bot to Write This Show https://www.bbc.co.uk/programmes/m001tmj6/episodes/player

Please provide any additional information below. Other shows have only some episodes with commas in their names, and only those episodes will fail.

jefro108 commented 8 months ago

There's a workaround if you go to BBC Sounds pages. It doesn't seem to add a series all at once for BBC Sounds but if you go to each individual episode eg https://www.bbc.co.uk/sounds/play/m001tj2g the page is recognised and will be added with the correct PID and the metadata is filled out before downloading

gadgetchnnel commented 8 months ago

Yes, it does work if I select each individual episode, but it's not just BBC SOunds that I've had the issue with. Here is another one - Coupling https://www.bbc.co.uk/programmes/p006cwvz/episodes/player That has a few episodes with commas in their names and you can see one of them below (episode title "Perhaps, Perhaps, Perhaps")

image

skovatch commented 8 months ago

Yup, I just reproduced it. Thank you for the report!

skovatch commented 6 months ago

Should be fixed with v1.26.1