search

Ascrod / readerview

Implementation of Firefox Reader View as an add-on for the Pale Moon web browser.
9 stars 3 forks source link

Improve shortcut configuration for international keyboard layouts #14

Closed Ascrod closed 6 years ago

Ascrod commented 6 years ago

Default Ctrl+Alt+R shortcut may be problematic or unusable for certain keyboard layouts, such as AltGr. Possibly provide an option to configure or disable the shortcut in about:config.

sergeevabc commented 6 years ago

Dear @Ascrod, Ctrl+Alt+R is used to restart the browser as well, so could you be so kind to accelerate implementing an option to customize the shorcut? Being an avid reader, I am in pain right now.

Ascrod commented 6 years ago

This issue is specifically about improving compatibility with international keyboard layouts. I have no control over what other extensions decide to use for their own shortcuts or whether people use extensions that have conflicting shortcut keys.

I have looked into making the shortcut configurable, but doing so will require a lot of additional overhead and a new UI for configuring the key. For the time being, it would probably be simpler to add an option to about:config for disabling the shortcut.

Ascrod commented 6 years ago

Added a preference to disable the shortcut key: b7eed443426e9d34274135ac8f3734d892b4fe01. Again, this may be made more configurable in the future, but for now I am marking this issue as resolved.

sergeevabc commented 6 years ago

Take a peep at the code of Fox Input extension, which binds Alt+J layout independently.