search

Ascrod / readerview

Implementation of Firefox Reader View as an add-on for the Pale Moon web browser.
9 stars 3 forks source link

Interferes with the local Pale Moon Start Page #23

Closed kasutajaimin closed 6 years ago

kasutajaimin commented 6 years ago

Buttons, enter on input stop working, search provider's logo disappears. (Double checked with only Tab Groups enabled)

But many thanks for the port! Really missed it.

waig3000 commented 6 years ago

The initial page search (about:home) d'not work when readerview is ative.

Ascrod commented 6 years ago

Thanks for the report, and apologies for not getting to it sooner. I can confirm that the add-on does indeed break the search feature and the buttons. What's interesting is that it isn't supposed to do anything with a page unless it's http or https. It may have something to do with the code that initializes and updates the button.

Ascrod commented 6 years ago

It's as I suspected. The declaration of the tab progress listener here: https://github.com/Ascrod/readerview/blob/a1630fbe7c674453770613c236ccf640d884ba04/chrome/content/readerMain.js#L40 Seems to overwrite a variable with the same name in Pale Moon's browser.js. I'm actually surprised this didn't break a lot more stuff. I'll move those "floating" declarations into the AboutReaderListener scope so that it won't be possible for any of that code to stomp on something else in the future.

I should be able to get a fix out for this in the next release.

kasutajaimin commented 6 years ago

Great! And absolutely no need to apologize. I'm grateful for any activity at all around Pale Moon, to anyone sparing their valuable time :bow:

Ascrod commented 6 years ago

Not a problem. :) Working on this add-on is (usually) more enjoyable than not, and I'm glad that people besides myself find it useful.

This issue should now be resolved with da0dab32128662ef70c81ae7390c48760cdae73c.