AsdarDevelops / PokeRogue-Events

Event's devving team fork for the browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
3 stars 1 forks source link

[Bug] Getting a mon KO'd by start of combat moves doesn't immeaditely prompt a switch #155

Open AsdarDevelops opened 3 weeks ago

AsdarDevelops commented 3 weeks ago

Describe the bug Some fights like Oricorio's ME option 1 have start of combat damaging moves. In this case, Oricorio boosts itself and then uses Revelation Dance on whichever Pokémon has been sent out ot the battle.

image

In some cases, this might lead to a K.O. of your own pokemon, such as in this image. After the K.O., the UI of having a pokemon sent out remains. This is not intended. Shown in the image:

image

Clicking "Fight" does not crash the game and leads to the PKMN selection screen, probably thanks to some safeguards in the code. Clicking "Pokémon" flashes the PKMN switch screen, and then shows again the PKMN switch screen, probably accounting that it was not possible to switch out a 0hp Pokémon.

Overall the bug is not super bad but it's def. noticeable and should be fixed.

Idk how this would be done, but I suppose that the "Start of combat" chain of moves should check HP of the player's sent out pkmn after each move (or each damaging) and interrupt itself and take the player to the switch pokemon screen if the players' pokemon has been fainted.