Asek3 / Oculus

GNU Lesser General Public License v3.0
110 stars 59 forks source link

Particle Ordering is problematic in all 3 modes. "mixed" causes particles to sometimes not rendered. "after" brings back vanilla bugs fixed by Iris/Oculus while shaders are off #520

Open TBlazeWarriorT opened 10 months ago

TBlazeWarriorT commented 10 months ago

What happened?

I've written a very detailed bug report about invisible particles under several circumstances, changing based on the particle rendering order defined on shaders.properties; Pretty much the entirety of that bug report also applies to Oculus, so I'm also reporting it here, in case it is relevant. I've (re)tested that entire bug report on Oculus and the behavior is the same, so this applies to both. Here's the original bug report: https://github.com/IrisShaders/Iris/issues/2198

TL;DR (even shorter here): On shaderpacks with particles.ordering=mixed on shaders.properties, Create mod moving contraptions (and possibly other particles) will flicker invisible/dislocated when you pick up a block. Disabling particles.ordering=mixed triggers the vanilla bug of not being able to see particles through translucents which was previously fixed by Iris/Oculus even when shaders are disabled.

Screenshots

I've also re-recorded the bug video on Oculus to prove it's the same (see context above). https://github.com/Asek3/Oculus/assets/25572454/7894dd55-9f86-4079-ac61-55298bccdc74

Relevant log output

No response

Minecraft Version

1.20.1

Oculus Version

oculus-mc1.20.1-1.6.13.jar

Rubidium Version

embeddium-0.2.13+mc1.20.1.jar (form still asks for Rubidium version, please fix too)

Operating System

Windows 10

What is your GPU?

RTX 2060

Java Version

Java 16 / 21.0.1 64-bit (MMC was using the JDK version but I have the other one too)

Additional context

No response

dima-dencep commented 8 months ago

form still asks for Rubidium version, please fix too

Fixed 😼