search

Asek3 / Oculus

GNU Lesser General Public License v3.0
115 stars 59 forks source link

The player's head is not displayed #601

Open MarioBlare opened 7 months ago

MarioBlare commented 7 months ago

What happened?

Description

The player's head will stop displaying if you wear the Barbaric Helmet from You've Goat to be Kidding Me along with the Snorkel from Artifacts. As far as I was able to find out, several modifications are involved in the appearance of the error at once. Also, the error is guaranteed to be reproduced only if the game created/overwritten configuration files at startup, in other cases, in other cases, the manifestation is due to conditions that I could not track. For example, if you use Quark, the error will be permanent, since this mod constantly updates its configuration file

List of mods

Embeddium (0.3.12) Oculus (1.6.15a) 3D Skin Layers (1.6.2) Architectury (9.2.14) Cloth Config API (11.1.118) Curios API (5.7.2) Artifacts (9.4.0) Moonlight Lib (2.11.9) You've Goat to be Kidding Me (1.3.4)

Reproduction steps

  1. Put the previously listed mods in one modpack
  2. Enter your world and put on the Barbaric Helmet, then place the Snorkel in the slot added by the Curios mod: Curios Inventory
  3. Switch to third-person mode and observe the absence of head texture behind the mask: Unexpected Behavior 3.1 How it should look like: Expected Behavior
  4. If the error disappears after restarting the client, delete the configuration of one of the mods and repeat

Screenshots

Third Person

Relevant log output

No response

Minecraft Version

Minecraft 1.20.1

Oculus Version

oculus-mc1.20.1-1.6.15a.jar

Rubidium / Embeddium Version

embeddium-0.3.12+mc1.20.1.jar

Operating System

Windows 10

What is your GPU?

Tested on three video subsystems: RTX 3050 Ti Laptop / AMD Radeon R9 280X / AMD Radeon (TM) Graphics

Java Version

JDK 17

Additional context

The bug does not appear on the inventory screen and in the 3D Skin Layers settings menu. Removing Oculus or Skin Layers 3D will cause the problem to disappear. In addition, the problem disappears when you turn on shaders. That is why the bug report was created here, and not on the pages of other mentioned mods. The problem is reproduced in the same way on different systems

MarioBlare commented 7 months ago

Addition 1 If you disable the Entity Shadows parameter, the error will only be played if the player is looking in the direction of the sun. Probably the problem with the Mixin "features.render.entity.shadows.EntityRenderDispatcherMixin"

Addition 2 Embeddium 0.3.1 and Oculus 1.16.5 are the latest versions in which the error is guaranteed not to be reproduced