search

Asek3 / Oculus

GNU Lesser General Public License v3.0
114 stars 60 forks source link

Mekasuit render fix backport. #701

Closed KostromDan closed 1 month ago

KostromDan commented 1 month ago

Fixes https://github.com/Asek3/Oculus/issues/170

KostromDan commented 1 month ago

image

KostromDan commented 1 month ago

Noticed differences in tab length between GitHub and IDEs. If it looked correct in the IDE, it looked wrong on GitHub. When I fixed it in the GitHub editor and copied it back to the IDE, it started looking incorrect there. So, I replaced tabs with spaces, and now it looks correct in both places.

dima-dencep commented 1 month ago

Noticed differences in tab length between GitHub and IDEs

skill issue

KostromDan commented 1 month ago

Noticed differences in tab length between GitHub and IDEs

skill issue

https://github.com/Asek3/Oculus/blob/1.19.2/src/main/java/net/coderbot/iris/pipeline/newshader/ShaderKey.java#L63 Wdym, is it correct? In IntelliJ IDEA or VS Code it looks correct, but not on GitHub. How it looks on GitHub: image How it looks in IntelliJ IDEA(tabs are highlited): image

KostromDan commented 1 month ago

If you want I'll revert my fixes and apply only requested, but I think it should look correct on both IDEs and GitHub.

dima-dencep commented 1 month ago

I don't care how it looks to you, you can see how it looks to everyone in your own pr and I don't understand why you don't see these changes in diff