search

Asek3 / Radium

Radium is an Unofficial Fork of CaffeineMC's "Lithium", made to work with Forge Mod Loader.
GNU Lesser General Public License v3.0
14 stars 4 forks source link

[1.18.2] Villagers fail to recognize any non-vanilla job site blocks #21

Open XanderHess opened 2 years ago

XanderHess commented 2 years ago

Forge version:

Mod versions:

If villagers have already acquired a modded profession before introducing Radium, once Radium is installed destroying the existing job site blocks will cause those villagers to not lose their profession while at the novice level. When placing/destroying a vanilla job site block (tested with Stonecutter/Mason villager) profession is acquired/lost as expected.

This issue can be observed with any combination of those mods installed - with and without More Villagers - so it's probably unrelated to the fix from Asek3/Radium@f5412d1

XanderHess commented 2 years ago

Having looked into the recent code changes, it looks like the previously mentioned fix has been invalidated with the changes in Asek3/Radium@4f8e23a.

ai.poi.fast_init.PointOfInterestTypeMixin has been replaced with ai.poi.PointOfInterestTypeMixin as far as I can tell.

The issue doesn't appear when disabling the ai.poi mixin through mixin.ai.poi=false in radium.properties, so doing a similar check for the presence of any of the affected mods in shouldApplyMixin() might act as a band-aid fix again.