Asek3 / Rubidium

Rubidium is an Unofficial Fork of CaffeineMC's "Sodium", made to work with Forge Mod Loader.
GNU Lesser General Public License v3.0
116 stars 54 forks source link

Minecraft 1.20.1 #703

Open koder1337 opened 6 months ago

koder1337 commented 6 months ago

---- Minecraft Crash Report ---- // Why did you do that?

Time: 2023-12-19 00:37:57 Description: Encountered exception while building chunk meshes

java.lang.NullPointerException: Cannot invoke "net.minecraft.client.renderer.texture.TextureAtlasSprite.m118367(double)" because "sprite" is null at me.jellysquid.mods.sodium.client.render.chunk.compile.pipeline.FluidRenderer.render(FluidRenderer.java:340) ~[rubidium-mc1.20.1-0.7.1.jar%23342!/:?] {re:classloading} at me.jellysquid.mods.sodium.client.render.chunk.compile.tasks.ChunkBuilderMeshingTask.execute(ChunkBuilderMeshingTask.java:125) ~[rubidium-mc1.20.1-0.7.1.jar%23342!/:?] {re:mixin,re:classloading,pl:mixin:APP:flywheel.sodium.mixins.json:ChunkBuilderMeshingTaskMixin,pl:mixin:A} at me.jellysquid.mods.sodium.client.render.chunk.compile.tasks.ChunkBuilderMeshingTask.execute(ChunkBuilderMeshingTask.java:45) ~[rubidium-mc1.20.1-0.7.1.jar%23342!/:?] {re:mixin,re:classloading,pl:mixin:APP:flywheel.sodium.mixins.json:ChunkBuilderMeshingTaskMixin,pl:mixin:A} at me.jellysquid.mods.sodium.client.render.chunk.compile.executor.ChunkJobTyped.execute(ChunkJobTyped.java:44) ~[rubidium-mc1.20.1-0.7.1.jar%23342!/:?] {re:classloading} at me.jellysquid.mods.sodium.client.render.chunk.compile.executor.ChunkBuilder$WorkerRunnable.run(ChunkBuilder.java:186) ~[rubidium-mc1.20.1-0.7.1.jar%23342!/:?] {re:classloading} at java.lang.Thread.run(Thread.java:833) ~[?:?] {}

Make a fix that checks sprite value for null and then do function calling.

if(sprite != null) { ... } else { Logger.Log("Sprite was null"); }