search

Asek3 / sodium-1.12

just a sodium for 1.12
https://legacy.curseforge.com/minecraft/mc-mods/embeddium
GNU Lesser General Public License v3.0
142 stars 25 forks source link

Blocks using Fluidlogged API don't show water #6

Open ralseilii opened 7 months ago

ralseilii commented 7 months ago

Bug Description

Some water-containing blocks in certain mods cannot contain water, such as oceanic expanse mod seagrass and most of the marine plants in prehistoric nature mod, even cannot contain water when adding the Fluidlogged-API mod.

Reproduction Steps

open game with oceanic expanse mod and vintagium, then find ocean

Log File

no log

ralseilii commented 7 months ago

by the way, when installing it alongside CensoredASM, enabling 'onDemandAnimatedTextures=true' in CensoredASM's config will result in the loss of all dynamic textures, such as fire and flowing water.

jbredwards commented 7 months ago

The fluidlogged api issue is something that needs to be fixed from both mods' ends. When I release the next update for that mod (or when the source code is on github), I'll start working on a PR to vintagium for compatibility

embeddedt commented 7 months ago

by the way, when installing it alongside CensoredASM, enabling 'onDemandAnimatedTextures=true' in CensoredASM's config will result in the loss of all dynamic textures

This is fixed now

ralseilii commented 7 months ago

The fluidlogged api issue is something that needs to be fixed from both mods' ends. When I release the next update for that mod (or when the source code is on github), I'll start working on a PR to vintagium for compatibility

thank you really hoping for it

ralseilii commented 5 months ago

well will it be fixed

jbredwards commented 5 months ago

well will it be fixed

Yes:

The fluidlogged api issue is something that needs to be fixed from both mods' ends. When I release the next update for that mod (or when the source code is on github), I'll start working on a PR to vintagium for compatibility

The next update for fluidlogged api is mostly done, it's just in the polishing/bug fixing stage now

LuizLoyola commented 1 month ago

Did this update release? Tested with Fluidlogged API v2.2.7, Vintagium v0.1 (Build 78) and Oceanic Expanse v1.1.2, problem still there.

LuizLoyola commented 1 month ago

Just tested with Biomes O' Plenty, and their "waterlogged" blocks are also bugged, so it doesn't look like a Fluidlogged API bug. Is Vintagium/Sodium 1.12 still in development? Last actual commit was 6 months ago...

KuroNeko87 commented 1 month ago

2024-07-28_01 43 14 2024-07-28_01 43 54

Yep, still there. Be using Opticrap for now until (hopefully) this gets fixed.