Aseni-Jayarathne / ISAC_Symbol_Demodulation

Joint Receiver Design for Integrated Sensing and Communications (https://ieeexplore.ieee.org/document/10121420/)
16 stars 1 forks source link

Fig.3:. Sensing performance using different modulations with fixed sensing power (γ = 1) and varying communication power (β ∈ [10−3, 103]). #1

Open pds001 opened 1 month ago

pds001 commented 1 month ago

Hello, I am trying to reproduce Figure 3 in your paper, but the result of my reproduction is not consistent with the 16QAM result in your paper. At present, we have not found the reason, hope to get your help!

Aseni-Jayarathne commented 4 weeks ago

Hello! I updated the GitHub code. The constellation set must be scaled to reproduce the results in the following paper. Joint Receiver Design for Integrated Sensing and Communications ( https://ieeexplore.ieee.org/document/10121420/)

Thank you.

On Sun, Oct 13, 2024 at 4:10 AM pds001 @.***> wrote:

Hello, I am trying to reproduce Figure 3 in your paper, but the result of my reproduction is not consistent with the 16QAM result in your paper. At present, we have not found the reason, hope to get your help!

— Reply to this email directly, view it on GitHub https://github.com/Aseni-Jayarathne/ISAC_Symbol_Demodulation/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCKLSBWQPEOQ2ODYEPZPC6LZ3IIWRAVCNFSM6AAAAABP3EIE7OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DGNZQGQZTIMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

pds001 commented 4 weeks ago

Hello! I updated the GitHub code. The constellation set must be scaled to reproduce the results in the following paper. Joint Receiver Design for Integrated Sensing and Communications ( https://ieeexplore.ieee.org/document/10121420/) Thank you. On Sun, Oct 13, 2024 at 4:10 AM pds001 @.> wrote: Hello, I am trying to reproduce Figure 3 in your paper, but the result of my reproduction is not consistent with the 16QAM result in your paper. At present, we have not found the reason, hope to get your help! — Reply to this email directly, view it on GitHub <#1>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCKLSBWQPEOQ2ODYEPZPC6LZ3IIWRAVCNFSM6AAAAABP3EIE7OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DGNZQGQZTIMQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

Thank you very much for your reply, I am trying the method you said. In addition, I would like to ask if you can provide some help for the part B. Optimal Design: Non-IC. I tried to reproduce this part, and the following is my code, but the result is incorrect: % Non-IC MMSE estimate num = 0; denom = 0;

for k = 1:M ref = h_c(:, jj) constellation(k); Exp_term = exp (rxSig - ref) '(0.5 inv (R) (rxSig - ref)); num = num + (rxSig - ref) * exp_term; denom = denom + exp_term; end

% Calculates an estimate of alpha alpha_hat_NIC(jj) = (g' inv(R)) (num / denom); end

% Calculates the MSE and stores it mse_NIC = [mse_NIC, immse(alpha, alpha_hat_NIC)];

Aseni-Jayarathne commented 4 weeks ago

Hello, Unfortunately, I only implemented the first part.

Thank you.

On Mon, Oct 14, 2024 at 10:24 PM pds001 @.***> wrote:

Hello! I updated the GitHub code. The constellation set must be scaled to reproduce the results in the following paper. Joint Receiver Design for Integrated Sensing and Communications ( https://ieeexplore.ieee.org/document/10121420/) Thank you. … <#m-1491280965804072388> On Sun, Oct 13, 2024 at 4:10 AM pds001 @.> wrote: Hello, I am trying to reproduce Figure 3 in your paper, but the result of my reproduction is not consistent with the 16QAM result in your paper. At present, we have not found the reason, hope to get your help! — Reply to this email directly, view it on GitHub <#1 https://github.com/Aseni-Jayarathne/ISAC_Symbol_Demodulation/issues/1>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCKLSBWQPEOQ2ODYEPZPC6LZ3IIWRAVCNFSM6AAAAABP3EIE7OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DGNZQGQZTIMQ https://github.com/notifications/unsubscribe-auth/BCKLSBWQPEOQ2ODYEPZPC6LZ3IIWRAVCNFSM6AAAAABP3EIE7OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4DGNZQGQZTIMQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

Thank you very much for your reply, I am trying the method you said. In addition, I would like to ask if you can provide some help for the part B. Optimal Design: Non-IC. I tried to reproduce this part, and the following is my code, but the result is incorrect: % Non-IC MMSE estimate num = 0; denom = 0;

for k = 1:M ref = h_c(:, jj) constellation(k); Exp_term = exp (rxSig - ref) '(0.5 inv (R) (rxSig - ref)); num = num + (rxSig - ref) * exp_term; denom = denom + exp_term; end

% Calculates an estimate of alpha alpha_hat_NIC(jj) = (g' inv(R)) (num / denom); end

% Calculates the MSE and stores it mse_NIC = [mse_NIC, immse(alpha, alpha_hat_NIC)];

— Reply to this email directly, view it on GitHub https://github.com/Aseni-Jayarathne/ISAC_Symbol_Demodulation/issues/1#issuecomment-2412604087, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCKLSBUSXTRCAHQI22FULUTZ3RRUVAVCNFSM6AAAAABP3EIE7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJSGYYDIMBYG4 . You are receiving this because you commented.Message ID: @.***>

DivyaG2024 commented 1 week ago

Sir, May I know the logic of choosing constellation(k) in the refernce signal instead of using the s(n) as mentioned in the paper. When I tried with s(n), here the transmitted communication signal it not working and getting a constant line BER and reverse MSE. ref = w_H Q h_c(:, jj) * s_t_commsig;

may I know the logic behind using constellation(k).

I tried so far and getting stuck. Please share.

Thank you.