search

Asgaros / asgaros-forum

Asgaros Forum WordPress plugin repository.
https://asgaros.com
GNU General Public License v2.0
90 stars 34 forks source link

Suggested improvements to topic/post notification emails, including #… #346

Closed glorious1 closed 2 years ago

glorious1 commented 2 years ago

…##FORUM### replacement

glorious1 commented 2 years ago

This is the first time I've ever tried to contribute to anything and do a pull request. What does it mean that you assigned me? Am I supposed to do something more?

Asgaros commented 2 years ago

Hello @glorious1

No, dont worry. Its just for me as a reference. Can you provide some more details about the changes? I roughly get the idea by reading your code-changes, but just to double-confirm. Is it based on a discussion in one of the support-topics in the forums?

I will approve the changes soon and merge it into the dev-version afterwards.

glorious1 commented 2 years ago

There were a couple of posts in your forums I recall that asked to see the forum name in the email along with the topic, and it seemed like a good idea to me too. Beyond that, it's just providing more information in the emails about how subscriptions work and how to change them, and putting apostrophes "\'" in don't.

In forum-notifications.php, for new post notifications: 206 get the forum name, which is easy because in line 201 you already got the forum object or array, whatever it is. 222 add the ###FORUM### replacement Then do the same thing for new topic notifications

In forum.php, the actual email text/templates are edited, as described above.