Asgaros / asgaros-forum

Asgaros Forum WordPress plugin repository.
https://asgaros.com
GNU General Public License v2.0
90 stars 34 forks source link

wrong output data in version 2.2.1 #359

Closed seema84 closed 1 year ago

seema84 commented 1 year ago

The latest Version (https://github.com/Asgaros/asgaros-forum/commit/e5f535dce86cd955b80cbda940b558d9a2879584) break my widget design. Here the CSS class style-block is missing and has been replaced by style-widget.

Asgaros commented 1 year ago

Hello @seema84

Can you provide a screenshot with an example?

seema84 commented 1 year ago

before the update

12 12c

after this update

13 13c

hope this helps (i also tried to write to you on fb so i could explain this better, but you don't seem to be really active there anymore :D)

I have temporarily fixed it like this:

    echo wp_kses_post($args['before_widget']);
    echo wp_kses_post($args['before_title']);
    echo esc_html($title);
    echo wp_kses_post($args['after_title']);
    echo wp_kses_post($output);
    echo wp_kses_post($args['after_widget']);

to

    echo $args['before_widget'];
    echo $args['before_title'];
    echo $title;
    echo $args['after_title'];
    echo $output;
    echo $args['after_widget'];

in widget-recent-posts.php and widget-recent-topics.php

However, I am sure that this cannot be a permanent solution.

Asgaros commented 1 year ago

Thanks, I will have a look into that.

The shown changes got applied due to a security audit by the WordPress team. I know they mostly doesnt make any sense at that point but I risked a de-listening from the plugin repository otherwise. I will check what I can do and keep you updated here.

And sorry for the delay in response. I am currently in Shanghai and thats one of the reasons why Facebook is not my main communication channel anymore. :)

Asgaros commented 1 year ago

Will revert that special escaping in the next version. WordPress Core is not even doing it by themselves and the documentation suggests doing it in the same way: https://developer.wordpress.org/themes/functionality/widgets/#sample-widget

seema84 commented 1 year ago

Thank you very much. I have already seen that you are in Shanghai. I hope you have a good time.