Ash258 / Scoop-GithubActions

Deprecated. Use https://github.com/shovel-org/GithubActions
MIT License
25 stars 18 forks source link

Pull requests actions #14

Open Ash258 opened 5 years ago

Ash258 commented 5 years ago

Triggers

Checks

  1. [x] Description
  2. [ ] License (Add note to children list, about what is wrong)
    • License property exists, but it is not valid SPDX identifier
  3. [x] Hashes
  4. [x] Checkver
  5. [x] Autoupdate
  6. [ ] Install (#59)
  7. [ ] Format (#24)

Expected comment:

Thanks for contributing. Your PR did not pass requirements.

### Manifest 1

- [x] Description
- [ ] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate

### Manifest 2

- [x] Description
- [x] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate
Thanks for contributing. PR looks good.

Wait for review from human collaborators.

Implementation:

Best possible to temporary save into some hashtable:

@{name = 'Manifest1'; 'Checkver' = Passed; 'Properties': 'OK | list of failed properties'}

Ash258 commented 5 years ago

Rework test-hash function to be reusable.

There is no need to do it this hard way. Keep it capturing streams and wait for binaries rework

Ash258 commented 5 years ago

Resolve how to run tests in context of pull request files

DONE

Ash258 commented 5 years ago

Try PR from forked repository

DONE

Ash258 commented 5 years ago

Basic implementation is done.

Now comes more problematic things:

- Install check - Format check

Issue description

Ash258 commented 5 years ago

When invoking from forked repository, context is on current repository not forked.

Investigate how to do it with push event

Rather do it with custom cloning forked repository

Ash258 commented 5 years ago

Add more license checks:

- [x] If property exists - [ ] If it is valid spdx identifier - [ ] No? Is there URL?

```md - [ ] License - [ ] Valid SPDX Identifier - [ ] Invalid + URL ```

This will require adding $Indent switch to create-new-checklist function

21

Ash258 commented 5 years ago

Add note about log:

Please see run log for pure result of all checks

Ash258 commented 5 years ago

Forked repositories are now covered and working.

Ash258 commented 5 years ago

Pull request comments with /verify are handled

Ash258 commented 5 years ago

For first release this is enough.

Install and format will come in future versions