search

Ash258 / Scoop-GithubActions

Deprecated. Use https://github.com/shovel-org/GithubActions
MIT License
25 stars 18 forks source link

Exit action with nonzero codes #18

Closed Ash258 closed 5 years ago

Ash258 commented 5 years ago

PR action should exit with nonzero code if there is some proble (block PR merging)

In other actions I feel comment is better than failed actions

Ash258 commented 5 years ago

For PR checks it is already done

Ash258 commented 5 years ago

Consider non zero exit codes in more actions

Ash258 commented 5 years ago

Only PRs (and Pushes in future) should end with non zero exit code on problem.

Other actions are better to end always with 0 and reflect status in comment