[Discussion] Should be push action handled?

Ash258 / Scoop-GithubActions

Deprecated. Use https://github.com/shovel-org/GithubActions

MIT License

25 stars 18 forks source link

[Discussion] Should be push action handled? #5

Closed Ash258 closed 5 years ago

Ash258 commented 5 years ago

On push it could handle various things:

Hash check
URL validity
Extract_dir
...

Relate: lukesampson/scoop#2667

Ash258 commented 5 years ago

I would propose this implementation:

There will be one main issue to collect these errors

Something like Pipeline updated manifests problems ...

workflow "updated manifest" {
    on = "push"
    resolves = ["push verify"]
}

action "push verify" {
    use = "..."
    args = "...."
    env = {
        "PIPELINE_ISSUE_ID" = "432423"
    }
}

Then if installation of application failed new comment to this issue will be created.

Ash258 commented 5 years ago

It could handle same things as PR action

Ash258 commented 5 years ago

Will not be implemented. Unless there will be enough people to request this.