search

AshDevFr / encounters_app

https://encounters.4sh.dev
2 stars 0 forks source link

Bug Report: Wrong AC displayed #11

Open FerrocCaldrson opened 4 years ago

FerrocCaldrson commented 4 years ago

Describe the bug When I open my DNDBeyond Campaign page, the stats of all the characters are shown (as expected), except that the AC's of a few of the PC's are shown as 10 higher than the actual value. This is not always the case, as it seems to only affect those PC's who have armour in their equipment. Those with Unarmoured Defense or no armour at all don't seem affected.

To Reproduce Steps to reproduce the behavior: Literally just click on the campaign button from the top right hand drop down menu and choose a campaign.

Expected behavior Accurate information of character stats displayed.

Screenshots image

Desktop (please complete the following information):

AshDevFr commented 4 years ago

Hi @FerrocCaldrson, could you please provide a link for your characters?

AshDevFr commented 4 years ago

I was able to identify an issue with AC due to a recent change in the API. I pushed a fix that will be published soon in v1.2.2 Let me know if it fixes the issue.

FerrocCaldrson commented 4 years ago

https://www.dndbeyond.com/campaigns/1221441

Here is a link to the campaign if it helps. Appreciate the hard work!

FerrocCaldrson commented 4 years ago

I think that did it - v.1.2.2 is installed and correct AC's seem to be consistently displayed. Thanks very much!

FerrocCaldrson commented 4 years ago

OK, so a couple of the characters in my campaign have received new armour. One has received platemail, the other half plate. Both of their AC's do no display correctly - the half plate character shows her AC as one higher than it should be and the plate wearer's AC has not changed since he replaced his chainmail with plate.

https://www.dndbeyond.com/campaigns/1221441 for reference.

The plate wearer is Ambrose, the half plate is Thyra

Bapawe commented 4 years ago

OK, so a couple of the characters in my campaign have received new armour. One has received platemail, the other half plate. Both of their AC's do no display correctly - the half plate character shows her AC as one higher than it should be and the plate wearer's AC has not changed since he replaced his chainmail with plate.

https://www.dndbeyond.com/campaigns/1221441 for reference.

The plate wearer is Ambrose, the half plate is Thyra

I've the same problem with characters in heavy armor, i think it's because the extensions also adds their Dex bonus to the AC which should not happen if someone is wearing heavy armor.