[Fabric 0.11.7 MC1.17.1 v: 1.3.1] Intense FPS lag when opening a cabinet

[Vapaman]

FPS normally FPS when viewing an cabinet inventory Bigger inventories mean much more lag

This is not a mod conflict issue as the lag is also present even when this is the only mod installed I hope you can do something to this issue because it makes the mod borderline unusable for those with lower spec computers

[AshIndigo]

Thank you for the report! I'll see what I can do about this and get back to ya when I got something

[AshIndigo]

So good news, got an easy solution to this whole issue already sitting around. I was planning on releasing this version once 1.18 dropped. But might as well do it now if it fixes this performance issue.

If your willing to give it a quick test run, install https://www.curseforge.com/minecraft/mc-mods/architectury-fabric and try using this build. Saves should be cross compatible between the current libgui based fabric version and this architectury version.

1.17.1-StorageCabinet-1.4.0-fabric.zip (Make sure you extract the .jar)

Still make a backup of your world though for good measure lest you risk item loss

[itsdinkd]

does this fix the performance issues with Indrev pipes (and using servo retriever) and Tom's Storage pipes?

[AshIndigo]

Yeah this build also includes the performance fix for cabinets that made their "is item valid" check faster. So it'll probably help with that as well

[itsdinkd]

Awesome, thank you!

[Kronon-Conspirator]

tested the 1.4.0 fix, good thing it fix the individual cabinets interaction. bad thing is the cabinet manager still lags intensely. just for ref on how many the cabinet is connected

[AshIndigo]

@Vapaman Any issues on your end with the build I uploaded?

Kronon for you though, I don't seem to notice any FPS drops in my dev environment when using the manager. If you want, I can try running your world/pack on my end to see if I can see it then. Is your pack available on CF by any chance?

[Kronon-Conspirator]

@AshIndigo sadly no as it has mods from multiple sources and even libraries for some reason CF doesn't want to approve of it (its the FTLib btw :D ). i do have a discord server where i catalogue my pack if your still interested in looking into it.

[Vapaman]

Sorry for a late reply. Tested the build you linked (1.4.0) and the performance has greatly increased. The fps lag that I get is comparable to lag that vanilla chests cause when opened (a drop of 10 fps with no performance mods).

Edit: In this build the cabinets don't work properly since you can only put only one stack of items in it. The rest of the slots don't accept items, but I expect this will be fixed in a proper release.

[AshIndigo]

1.17.1-StorageCabinet-1.4.1-fabric.zip

@Vapaman Here, this new build should fix the cabinet related issues and maybe an extra performance boost.

@Kronon-Conspirator If you want to try this as well, would be much appreciated

As always, keep a backup of your world and all that jazz before using this since it's a beta version

[Kronon-Conspirator]

result from 1.4.1, like before individual interactions are improved drastically tho the yellow fps spikes seen in the pic is cause from opening the cabinets. unsure this is normal behavior. and like before as well the cabinet manager spike still present

[AshIndigo]

Ok, spun up the pack myself and figured out how to work a profiler so I could do some better testing.

Looks like either my code or the mod Smooth Scrolling really doesn't like my GUI's. Would personally recommend disabling it until a fix is found.

REI doesn't seem to be happy as well, which I will have to look into. Turning it off via the keybind fixes the FPS issues from that as well.

I'll post again later when I have a fix for this issues. Thank you all for reporting these issues

[Vapaman]

Nice, version 1.4.1 works and runs like a charm. Also seems like REIs performance is less than ideal to say it nicely.