AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)
GNU General Public License v2.0
321 stars 358 forks source link

Scripts/EasternKingdoms Arathi Highlands Alliance quests working, oth… #101

Closed AussieGlenn closed 6 years ago

AussieGlenn commented 6 years ago

…er adjustments

Changes proposed:

Alliance/Neutral quests only!

Fix one broken quest, multiple overspawns/adjustments

Issues addressed: Closes # (insert issue tracker number)

Tests performed: (Does it build, tested in-game, etc.)

Compiled, tested with 2 characters

Known issues and TODO list: (add/remove lines as needed)

AussieGlenn commented 6 years ago

Hi Traesh,

With quest 26049, using the item and intercepting the spell did not want to work, effect_ids not matching up, checked sniffs and DBC, but no amount of bashing would get it to work, so used a dummy with 10 yard radius to summon Myzrael, and it seems to work fine.

Note, with Myzrael this will need at least 3-4 characters with scaling and the SAI working properly, even with my 10% of normal damage cheat it was a close run thing.

Note, this will need more work when I finish all Alliance areas as there are Horde quests untested.

Thanks,

Glenn

Traesh commented 6 years ago

@AussieGlenn spell should be fixed now :)

So i removed the dummy npc, and even if i have absolutly no problem if you do dummies, be careful about the id you take, in that case it was a dummy from another quest item (https://fr.wowhead.com/item=33129), it could have lead to errors

AussieGlenn commented 6 years ago

Hi Traesh,

Should this line:

RegisterSpellScript(npc_myzrael_bunny);

be

RegisterSpellScript(spell_summon_myzrael);

?

Thanks,

Glenn

leviathonbeast commented 6 years ago

@AussieGlenn fixed.

AussieGlenn commented 6 years ago

Hi @leviathonbeast ,

Nope, at work still, will test and report back.

Thanks,

Glenn