Spells/Druid Add Highmountain Tauren druid forms

AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)

GNU General Public License v2.0

321 stars 358 forks source link

Spells/Druid Add Highmountain Tauren druid forms #104

Closed kytulendu closed 6 years ago

kytulendu commented 6 years ago

Changes proposed:

Add Highmountain Tauren druid forms Because missing druid's shape-shift forms is more important than missing/broken druid's spells ;3

Issues addressed:

https://bt.ashamane.com/view.php?id=106

Tests performed:

Compiled on Kubuntu 18.04. Tested in-game.

Known issues and TODO list:

Not Retail-like. Need someone to check Highmountain Tauren cat/bear form fur color against Retail, as I haven't unlock allied races on Retail yet XD

Although I code it so that cat/bear form fur color match fur color logically.

Traesh commented 6 years ago

Most important commit ever, you don't know how many times druid player asked me about that :D

I can ask Kittens to check as he unlocked highmoutain tauren

leviathonbeast commented 6 years ago

i can check this now im home again

Edit : Tested cant seem to find this 80600 id in my sniff i dont think its correct default.

All else is good :) its mergable.

kytulendu commented 6 years ago

I don't really know if id 80600 was really use or not, as I'm not use any sniff when I write all the patch I submit (I use blackbox testing and wowhead changelog method and find the morph id using in-game model viewer addon X3).

As there is 5 difference Highmountain Tauren bear/cat forms but Highmountain Tauren have only 4 fur colors options and one of the cat form (id 80600) horns and fur color was mis-match, so I think 80600 might be good to use as a default... which the code path probably not gonna executed as Highmountain Tauren have only 4 fur colors options (skinColor = 0, 1, 2, 3)...