AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)
GNU General Public License v2.0
320 stars 352 forks source link

Scripts/EasternKingdoms Duskwood quests/spawns fixed, but needs more … #111

Closed AussieGlenn closed 6 years ago

AussieGlenn commented 6 years ago

…work for 2 non-working quests

Changes proposed:

Fix every Duskwood quest Adjust spawns/other changes

Credit to @Caydan for some scripts, thanks very much.

Issues addressed: Closes # (insert issue tracker number)

Tests performed: (Does it build, tested in-game, etc.) Compiled, tested with 2 characters

Known issues and TODO list: (add/remove lines as needed)

AussieGlenn commented 6 years ago

Hi Traesh/everyone,

There are two non-working quests, and this should not be committed until these are working.

If someone can patch the files so I can get

  1. The https://www.wowhead.com/spell=82029/call-stalvan to cast
  2. The https://www.wowhead.com/quest=26760/cry-for-the-moon quest to be offered

Then I can complete the scripts and do more testing.

All other quests apart from these two working.

Thanks,

Glenn

leviathonbeast commented 6 years ago

the quest should be offered after completing the previous steps in the chain are you not going through the chain correctly when you test?

https://www.youtube.com/watch?v=Rr7psKIfmtE

looks like some work for you there :D

Traesh commented 6 years ago

AussieGlenn : You should spawn gameobject 301070 in order to be able to cast 82029

You can then make a ZoneScript for Duskwood (Example : https://github.com/AshamaneProject/AshamaneCore/blob/master/src/server/scripts/BrokenIsles/zone_dalaran_legion.cpp#L210) and override method

void ProcessEvent(WorldObject /obj/, uint32 /eventId*/) { }

Check for eventId 25759 and obj will be the focus gameobject, 301070. From there you can spawn stalvan in that method

AussieGlenn commented 6 years ago

Hi @leviathonbeast ,

I had the chain set, removed it trying to get it to work.

Right now, there are no restrictions on that quest, and it will still not offer it.

Maybe there is a debug command to work out why?

Hi @Traesh ,

I will trace that in my morning, and follow your guide.

Thanks,

Glenn

AussieGlenn commented 6 years ago

Hi Traesh,

The spellfocus gameobject was exactly the fix, the two sniffs I had do not have it at all.

Now to bash this quest again to see if it will be offered.

Thanks,

Glenn

AussieGlenn commented 6 years ago

Some bright and caring person put this quest in the disables table.

Now showing, so will fix up chains and do more testing, with a final fix up in a day or so

AussieGlenn commented 6 years ago

Hi Traesh,

Please hold off for one more day on this PR, I want to put a clean character through it.

Thanks,

Glenn

AussieGlenn commented 6 years ago

Hi Traesh,

This is ready to go, please make any adjustments you see fit.

Thanks,

Glenn