[HackFix/CRASH] GetSpellScalingColumnForClass

AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)

GNU General Public License v2.0

321 stars 358 forks source link

[HackFix/CRASH] GetSpellScalingColumnForClass #115

Closed DavidUlloaG closed 6 years ago

DavidUlloaG commented 6 years ago

Changes proposed:

Temp/Fix CRASH: https://bt.ashamane.com/view.php?id=635

Issues addressed: Closes # (insert issue tracker number)

Tests performed: (Does it build, tested in-game, etc.)

Known issues and TODO list: (add/remove lines as needed)

Traesh commented 6 years ago

This crash happen because you try to cast a player-only spell on a creature

DavidUlloaG commented 6 years ago

This crash was caused by normal players, after this hackfix we did not have more related crashes.

regards!

Traesh commented 6 years ago

Hello, Could you provide crashlog when this spell is casted by normal players ? In the one provided within the issue, it's casted by a creature with SAI

"0000011 0x0000000003765aea in SmartScript::ProcessAction"

Edit: The specific crash you posted is now fixed in 4b7c7f53e1b989c02ceddac5d160dfa330ec2f87