Restauration_Shaman_Mastery

Blackdiamond5 commented 6 years ago

Changes proposed:

Implementation of Restauration Shaman Mastery (Deep Healing, id=77226)
The aura corresponding to this spell is SPELL_AURA_MOD_HEALING_VS_HEALTH_TARGET_LOST (354)
The healing bonus is calculated in Unit::SpellHealingBonusDone
Mastery_pct is taken from the aura owner, Health_pct is taken from the target to compute target health lost pct. Then the healing amount is modified by mastery_pct*lost_health_pct. Hence when 0% health is lost, nothing happens and when X% health is lost, healing is increased by X% of the mastery_pct.

Issues addressed: Closes partially ticket 691 (only the restauration shaman part)

**Tests performed: Tested on my test server on every healing spell of the shaman

**Known issues and TODO list:

Issue : Does not work on Gift of the Naaru but that spell does not work as it should anyways
TODO : Elemental Shaman mastery needs to be investigate in order to close ticket 691
Note : As I am quite new on TrinityCore, DO NOT hesistate to check/comment/suggest/modify. It's always helpful to learn. Thanks.

leviathonbeast commented 6 years ago

how is this patch going?

Blackdiamond5 commented 5 years ago

Maybe later...

AshamaneProject / AshamaneCore