search

AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)
GNU General Public License v2.0
321 stars 358 forks source link

Fixed power consume Issue #239

Closed AzgathCore closed 4 years ago

AzgathCore commented 4 years ago

Changes proposed:

Target branch(es): 3.3.5/master

[ ] 3.3.5 [x] master

Issues addressed: Closes #24315 (insert issue tracker number)

Tests performed: (Does it build, tested in-game, etc.)

Tested Building Tested Ingame

Known issues and TODO list: (add/remove lines as needed) By @DuelistRag3

DuelistRag3 commented 4 years ago

Thanks for the Tag there <3

DuelistRag3 commented 4 years ago

Is it intendet that you renamed the header in the readme file? ^^

AzgathCore commented 4 years ago

Is it intendet that you renamed the header in the readme file? ^^

If the permissions allow me, why not ^^

AzgathCore commented 4 years ago

Thanks for the Tag there <3

With great pleasure :)

DuelistRag3 commented 4 years ago

Is it intendet that you renamed the header in the readme file? ^^

If the permissions allow me, why not ^^

True :D

mcsescott commented 4 years ago

Good updates, and I appreciate that.

However, I would deny this ... it includes a lot of "Azgath" stuff. That is perfectly fine on your own server, but shouldn't be changes on Ashamane core.

DuelistRag3 commented 4 years ago

Good updates, and I appreciate that.

However, I would deny this ... it includes a lot of "Azgath" stuff. That is perfectly fine on your own server, but shouldn't be changes on Ashamane core.

Ashamane and Trinitycore are not for server use mainly, they are educational software, so it does not matter what header it uses, and u can change it by urself any time

mcsescott commented 4 years ago

Ashamane and Trinitycore are not for server use mainly, they are educational software, so it does not matter what header it uses, and u can change it by urself any time

Completely understood and agree, but "Azgath" branding should not be on the Ashamane Core. I do think all the other changes are fine, though. Good stuff.

leviathonbeast commented 4 years ago

This PR will not be merged while there are not required edits to the worldserver config/readme

DuelistRag3 commented 4 years ago

Then just take out all azgathcore stuff or i will remake this pr @AzgathCore

AzgathCore commented 4 years ago

Hello to you

I'm new to GitHub so if you tell me I need to change the readme and configuration I'm ready to do it and update AzgathCore as often as possible :)

DuelistRag3 commented 4 years ago

You can just redo the changes you did to the banner and the readme and do a new commit into this pulll request (and of course reopen it)