search

AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)
GNU General Public License v2.0
321 stars 357 forks source link

GossipMenuItem doesn't working #271

Closed src893 closed 3 years ago

src893 commented 3 years ago

Description:

GossipMenu with codebox is not working since 9.x update.

Current behaviour:

1) Download sources

2) Create a small c++ script for an npc or gameobject and add an gossip item like this :

3) AddGossipItemFor(payer, GOSSIP_ICON_CHAT, "Hello this is a simple test.", GOSSIP_SENDER_MAIN, 0, "Hello this is a popup without codebox", 0, false); AddGossipItemFor(payer, GOSSIP_ICON_CHAT, "Hello this is a simple test.", GOSSIP_SENDER_MAIN, 0, "Hello this is a popup with codebox", 0, true);

4) Go ingame and test your script. No crash but nothing happen. This kind of gossipItem isn't working.

TC rev. hash/commit:

Latest build

Database version

ADB latest version

Operating system:

Windows

Traesh commented 3 years ago

What GossipHello method are you using ? It may be a simple merge error on my side

src893 commented 3 years ago

What GossipHello method are you using ? It may be a simple merge error on my side

OnGossipSelect OnGossipSelectCode

src893 commented 3 years ago

What GossipHello method are you using ? It may be a simple merge error on my side

Did u have test it? On my side nothing is working when I try to create an c++ gossip with mode OnGossipSelect and OnGossipSelectCode hook. OnGossipoHello hook is working as well but nothing else.

src893 commented 3 years ago

What GossipHello method are you using ? It may be a simple merge error on my side

Latest update solve partialy the problem. gossip with promotioncode is not handled correctly with OnGossipSelectCode method.