search

AshamaneProject / AshamaneCore

AshamaneCore Open Source MMO Framework (master = 9.0.2.36949, bfa = 8.3.7.35284, legion = 7.3.5.26972)
GNU General Public License v2.0
321 stars 358 forks source link

Fixed Hammer of the Righteous damage spread. #57

Closed TheXWolf closed 6 years ago

TheXWolf commented 6 years ago

Changes proposed: Fixed the Hammer of the Righteous spell to hit it's additional targets.

Issues addressed: Closes # (insert issue tracker number) Since you don't have an issue tracker can't really do that now can I? ;)

Tests performed: (Does it build, tested in-game, etc.) Built against current repo as of today. Tested in-game, functions as intended.

Known issues and TODO list: (add/remove lines as needed) Wave of light visual doesn't always appear.

leviathonbeast commented 6 years ago

We do have a issue tracker it’s bt.ashamane.com

TheXWolf commented 6 years ago

Good to know, lol. Didn't see a link on the git or on the homepage so I assumed you ripped it down after the dmca BS happened.

Traesh commented 6 years ago

Taken from Spellwork for the Hammer of the Righteous 53595 (french but doesn't matter for what's important) :

"Tant que vous vous tenez dans la zone d’effet de votre Consécration, Marteau du vertueux libère également une onde de lumière qui frappe les autres cibles à moins de $88263A1 mètres et leur inflige $88263sw1 points de dégâts du Sacré.][]"

The description use spell 88263 to display data, that mean your SPELL_HAMMER_OF_RIGHTEOUS_LIGHT_WAVE should be 88263

Plus spell 88263 use SPELL_EFFECT_WEAPON_PERCENT_DAMAGE which mean its damage are already handled, no need to CastCustomSpell