AshampooSystems / boden

Purely native C++ cross-platform GUI framework for Android and iOS development. https://www.boden.io
Other
1.68k stars 96 forks source link

WIP: ApplicationController::onOpenURL support #14

Open mrexodia opened 5 years ago

mrexodia commented 5 years ago

Based on #13

CMakeLists.txt:

[...]

ios_configure_app_info(TARGET Authenticator
    LAUNCHSCREEN "LaunchScreen"
    TARGETED_DEVICES IPHONE IPAD
    IPHONE_ORIENTATIONS ALL
    IPAD_ORIENTATIONS ALL
    URI_ROLE Editor
    URI_HANDLERS otpauth totp)

[...]

For now only iOS support, but there should be a similar feature on Android. No documentation was updated and only manual testing was performed (By scanning a QR code with an otpauth:// url and allowing it to open my app, see: http://security-totp.appspot.com).

Please let me know if this is a desired feature, I can do more work if needed but couldn't really find any contributor guidelines.

gitoby commented 5 years ago

Thanks for contributing!

We are currently in the process of ramping up our contribution guidelines and, most importantly, contribution license agreement. I will get back to you tomorrow.

gitoby commented 5 years ago

We've committed a Contribution License Agreement for Boden at https://github.com/AshampooSystems/boden/blob/master/CLA.md (CLA). Your consent is required for us to accept your contributions. Please review the agreement and let me know whether you agree to it. There is no need to sign the agreement for now. It is effective upon your submission — and in this special case — upon your consent here since the CLA has not been online when you submitted this PR.

mrexodia commented 5 years ago

Yeah the CLA looks fine for me and I agree to it!

gitoby commented 5 years ago

Great, thank you! We will review your PRs in the next days and get back to you if needed.

gitoby commented 5 years ago

Thanks a lot for adding this! Looks great! It's definitely a desired feature.

We don't have contribution guidelines (wip), so here are the most important points that I think you need to know:

Please let us know whether you are willing to put more work into this. If not, we'll be keeping this open and prioritize the feature in the next sprint planning meeting.

mrexodia commented 5 years ago

It's fine for me to put additional work into this feature. I discovered the .clang-format file yesterday and I will rebase and adjust the commits to format everything correctly.

I closed #13 because this PR includes those changes. And I made the free space to install Android Studio so I will at least get things to compile there and I will try to implement it this weekend when I'm back home.

gitoby commented 5 years ago

Great! Let me know if we can help. Looking forward to your PR!

mrexodia commented 5 years ago

For iOS this is working, unfortunately I'm having a really hard time working with Android Studio and my Android experience is very limited, so I won't be able to implement it there.

gitoby commented 5 years ago

OK, no problem. We will have a look. Thanks for your work on this!

cdelabrouhe commented 4 years ago

Is there any news about Boden ? Nothing for 8 months, is it still in dev ?

lexuanquynh commented 2 years ago

Is there any news about Boden ? Nothing for 2 years, is it still in dev ?

frak0d commented 2 years ago

Is there any active fork of boden ? I feel like this shouldn't die.