Ashar25 / RainyDay

0 stars 1 forks source link

Change location of storm catalog files #16

Closed danielbwright closed 1 year ago

danielbwright commented 1 year ago

Now that we are creating a lot of files, let's change the location in which they are saved. Specifically, let's use: "MAINPATH"/"SCENARIONAME"/"CATALOGNAME"

So, for example, the result could look like: /Users/daniel/Google_Drive/RainyDay2/Summer2023_RefactorTesting/RainyDay_MadisonExample_24hr_empirical_uncorrected_nclimgrid/Madison_ExampleCatalog_nclimgrid100.nc

Ashar25 commented 1 year ago

Yes, I was thinking to do this before pushing it here. I will do it. We can make separate folder for storm files in the mainpath or you want it in scenarioname?

danielbwright commented 1 year ago

This is a high priority.

Ashar25 commented 1 year ago

Done.

danielbwright commented 1 year ago

Can you point me to the code for this? It doesn't seem to be behaving any different than before.

Ashar25 commented 1 year ago

Are you able to merge my branch into yours ? Check line 181 in my branch for this particular issue.

danielbwright commented 1 year ago

Never mind, I'll fix it myself. It is a very minor issue.

Ashar25 commented 1 year ago

This is weird. I more worried about the merging part because it should have generated a separate folder for the catalogs. if CreateCatalog: try: os.mkdir(wd + '/' + 'Storm_Catalog') except OSError as exc: if exc.errno != 17: ### This checks the file exist error. '17' this is for file exist error. raise pass

This is the command I added. Let me know if these are there in the code or not.

danielbwright commented 1 year ago

yes, but it needed to be 'fullpath', not 'wd'. DOn't worry, I am fixing it.

Ashar25 commented 1 year ago

ok, actually I was trying to make a separate folder for storm catalogs in the mainpath apart from scenarioname.