search

Ashark / archlinux-amdgpu-pro

Radeon Software for Linux (AMDGPU PRO) PKGBUILD generator for ArchLinux AUR
https://aur.archlinux.org/pkgbase/amdgpu-pro-installer/
119 stars 25 forks source link

getting rid of dependency cycles #33

Closed brainpower closed 7 years ago

brainpower commented 7 years ago

by removing all dependencies to other amdgpu-pro packages from the amdgpu-pro package itself

For example: xf86-video-amdgpu-pro should depend on amdgpu-pro, but amdgpu-pro shouldn't depend on xf86-video-amdgpu-pro. So this removes the xf86-video-amdgpu-pro dependency from amdgpu-pro. And should therefore get rid of the dependency cycles...

AustinJ235 commented 7 years ago

I am testing this out on a fresh install of arch to see if my issue from the prior pull request still exists. I found that lib32-ncurses5-compat-libs lib32-libomxil-bellagio are missing as needed deps and aren't pull in for some reason with yaourt.

corngood commented 7 years ago

@brainpower Bear with me, just trying to wrap my head around this.

This will stop pacaur -S amdgpu-pro from actually installing everything, right? But is amdgpu-pro actually meant to be a meta package to install everything, or is it a core component that the other packages have a legit dependency on?

What's actually in amdgpu-pro?

Is it possible to pacaur -S amdgpu-pro-installer instead, to get everything?

brainpower commented 7 years ago

But is amdgpu-pro actually meant to be a meta package to install everything, or is it a core component that the other packages have a legit dependency on?

The latter, the mesa package works same way. When I changed the package structure I wanted to get close to how mesa packages work.

What's actually in amdgpu-pro?

Almost everything, except opencl, vulkan, vdpau and libdrm.

Is it possible to pacaur -S amdgpu-pro-installer instead, to get everything?

I could add a metapackage, I'd call it amdgpu-pro-meta, but we can go with amdgpu-pro-installer too... Or I could add all packages to a group, say ´amdgpu-pro-driver´, but I don't know if pacaur supports installing a group?

brainpower commented 7 years ago

@AustinJ235 thats off topic here, but: Both lib32-ncurses5-compat-libs and lib32-libomxil-bellagio are included in the depends-array of lib32-amdgpu-pro (see [1]), so if they don't get pulled, that's probably an issue/bug of yaourt. Edit: IIRC yaourt was always known for not dealing well with split packages...

[1] https://github.com/corngood/archlinux-amdgpu/blob/master/PKGBUILD#L219

corngood commented 7 years ago

@brainpower being like mesa is probably a good idea. I had seen someone report that pacaur -S amdgpu-pro showed the dependency problem, so I wasn't sure if that was the intended way of installing everything.

This will require installing the packages individually, but it's more fine grained and consistent with other packages, so LGTM.

I'll merge it and push it to AUR assuming you are still ok with it?

brainpower commented 7 years ago

Yeah, go for it.