search

Ashark / archlinux-amdgpu-pro

Radeon Software for Linux (AMDGPU PRO) PKGBUILD generator for ArchLinux AUR
https://aur.archlinux.org/pkgbase/amdgpu-pro-installer/
119 stars 25 forks source link

Avoid using hardcoded versions to stop flooding pkgbuild diffs in aur #60

Closed Ashark closed 5 years ago

Ashark commented 5 years ago

When you see changes of amdgpu-pro-installer PKGBUILD in aur, it is flooded with changed versions of deb files and in depends arrays. My commit prevents this for further updates. Please review. Also changed /bin/sh to /bin/bash to be able to use [[ while using script in debian. Also check if python-debian is installed before using debian module in gen script.

corngood commented 5 years ago

@Ashark I'm not actively using or maintaining this package. You're more than welcome to adopt it on AUR and push from your fork. I can link to it from this repo if you like.

Ashark commented 5 years ago

@corngood I will explore Debian packages and try to prepare them for Arch. I have adopted aur package. You mean you want make your repo like https://github.com/LEW21/archlinux-amdgpu ? If yes, then I think I should recreate my fork as a standalone repo (not fork), to allow others to use some GitHub features. Because as I remember, there are some limitations for forks of forks.

corngood commented 5 years ago

@Ashark yeah, this one started as a fork of LEW21, so doing the same again is fine with me. I'll put a message like that up once you've got a release on AUR.

Ashark commented 5 years ago

I have updated package in aur. I am going to remove my repo, then you do not delete your repo. Just make a transfer. This way all forks and issues will be kept.

corngood commented 5 years ago

Ok, I created a transfer request. You may need to do something on TravisCI for CI to continue working. Good luck.

Ashark commented 5 years ago

Ok, will check it later. Thank you!

brainpower commented 5 years ago

@Ashark ping me if you need help with anything. I'm not actively using the amdgpu drivers anymore but I occasionally experiment (not much lately, that's why I didn't do any updates)

Oh, and I'm the maintainer of linux-lts49-kallsyms on AUR, which was needed for this package at some point, so you may also ping me if you need anything related to it.

Have fun ;)

Ashark commented 5 years ago

@brainpower @corngood Do you remember why linux-lts49-kallsyms was needed?

corngood commented 5 years ago

@Ashark Yeah, there was some private symbol used in the driver, and I couldn't find any other way to get the address of it with an unmodified kernel. Unfortunately I can't find any notes about which one exactly, but I think it was some drm function. If you don't have KALLSYMS_ALL y, you'll get an unresolved symbol error in your kernel log when it loads the driver, at least with the last version I tested.

I would definitely recommend testing without it if you upgrade either the driver or the kernel.

Ashark commented 5 years ago

@corngood Thanks for quick response. I have a problem now. I have repacked packages that are used in ubuntu to arch packages, then installed them, but davinci-resolve works incorrectly. It does not crash silently, but pop ups an "Davinci Resolve quit unexpectedly" window. I have made amdgpu-pro 19.20 to work in ubuntu 19.04 with this script I uploaded here. In ubuntu 19.04 I have noted that kernel is 5.0.0-16-generic and xorg is 1.20.4. And davinci resolve works fine in ubuntu. But even when I downgraded linux and xorg in arch to these versions, it still did not work. So I suspected something like what you are talking about (some different kernel in ubuntu). How can I see if I have such an issue with unresolved symbol? dmesg | grep -i unresolved gives nothing.

corngood commented 5 years ago

@Ashark If there's an unresolved symbol, the kernel module wouldn't load, so you won't even get a video mode switch at boot, and the machine will stay in text mode.

Your problem seems to be in user-mode. Do you get any useful log output from davinci-resolve?

Does GL work (e.g. glxgears)?

Ashark commented 5 years ago

@corngood Sorry my late answer, github did not sent a notification email for some reason. Ok, then it seems I do not need that kernel. Then I will remove that info from sticked comment in aur. glxgears works. It is hard to say anything about davinci-resolve, but I will try to explore its logs.

Ashark commented 5 years ago

@corngood Good news. I have got a working state in Arch, yay! I have dropped most of the open components, just like I did for ubuntu 19.04 script in v05 (link above). And davinci resolve worked!

corngood commented 5 years ago

@ashark that's great. I'll be sure to take a look when I get a around to doing the upgrade on NixOS.

brainpower commented 5 years ago

@Ashark Well, when you release the version to the AUR that does not need linux-lts49-kallsyms anymore, please drop me a message either here on github or on the AUR. I'll gladly drop that package, the only real difference to linux-lts49 is that single kallsyms_all option anyway.

Ashark commented 5 years ago

@brainpower I have uploaded release to AUR Could you please review if I made external dependencies correctly. And If the following packages should be omitted or not:

brainpower commented 5 years ago

Sorry for the late response. External deps look good, but I didn't do any in depth tests. There will be people on AUR who report those anyway.

In regards to the opencl packages, maybe talk to the maintainer of 1 or look at the contents of that package. Anything that's duplicated there, you could omit from this package set...

Ashark commented 5 years ago

Packages listed above are those which are not duplicating opencl-amd. I contacted it's maintainer though. Actually I do not want to omit duplicated OpenCL implementation for now, because opencl-amd is not meant to be a proper package. And it lacks 32 bit orca implementation. So I think I will keep it for now. I have a problem with I+A gpu combo. But I think I will better open a new issue in this repo.