search

AsherGlick / Burrito

An overlay tool for Guild Wars 2 that works on linux
GNU General Public License v2.0
80 stars 19 forks source link

Update Godot version to 3.5.1 #130

Open royalmustard opened 1 year ago

royalmustard commented 1 year ago

Right now this project runs on Godot 3.3.2 (at least according to the CI file), the latest LTS version of Godot ist 3.5.1; This causes problems as some Systems automatically update Godot and the headers for GDNative changed between those versions, causing compilation of the parser and foreground script to fail.

AsherGlick commented 1 year ago

This seems like the wrong solution. The underlying problem here is version incompatibilities between Godot and the GDNative headers. There is no current native way for a Godot project to pin the version of Godot it is using, while there are ways to pin the GDNative header versions being used. So some systems can get out of sync.

All of the official builds for Godot are readily downloadable at https://downloads.tuxfamily.org/godotengine/ so asking the dev to use an older version is a really easy request, so long as they know they need to. And right now it is very non-obvious which version should be used because the only place that states the version is the CI file.

Probably what we will end up with in Burrito is an addon that prevents the project from being opened in any version of Godot other than a specified version, and gives the opener a popup with a direct link to download the correct version for the project. This will stay 3.3.2 for now, until there is a reason to upgrade to a newer version.