AsherGlick / Burrito

An overlay tool for Guild Wars 2 that works on linux
GNU General Public License v2.0
79 stars 18 forks source link

Achievement Bit Unsigned Int Linter #287

Open AsherGlick opened 4 months ago

AsherGlick commented 4 months ago

Achievement Bit / Achievement Bit Index is an unsigned int, it represent an index into an array. Any negative value is an invalid value, we should add a way to lint for this and when we do we can add the following tests back in to check that the linter catches the errors.

<POI AchievementBit="-2147483648" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" />
<POI AchievementBit="-5" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" />