search

AsherGlick / Burrito

An overlay tool for Guild Wars 2 that works on linux
GNU General Public License v2.0
79 stars 18 forks source link

XML parsing not working properly for Tekkits EOD markers #55

Open royalmustard opened 2 years ago

royalmustard commented 2 years ago

While I have not tested it yet on windows, something leads me to believe that this is not how the markers are supposed to look.

It creates an extra line from the center of the map to every zipline point.

image

AsherGlick commented 2 years ago

Is this using the embedded XML parser or is this using the conversion script?

royalmustard commented 2 years ago

I was loading the XML file directly from the "Open Markers File" dialog.

royalmustard commented 9 months ago

This seems to be caused by some trails using [0,0,0] as some kind of "null terminator" (see https://github.com/coderedart/jokolay/releases/tag/v0.2.2).

coderedart commented 9 months ago

Trails have multiple sections within the same trl binary file.

[1, 1, 1]
[2, 2, 2]
[3, 3, 3]
[0, 0, 0]
[2, 2, 2]
[1, 5, 3]

Treat [0, 0, 0] as a special null terminator that separates trail sections. So, the first 3 nodes and the last 2 nodes are separate trail sections, which must not be connected in anyway. I was really surprised to find that out :rofl:

AsherGlick commented 9 months ago

Ah drat, I could have been more informative in my original question. We actually handled this in the manual converter step. https://github.com/AsherGlick/Burrito/blob/02fc3afaead1a6b3d5d7e75364d3614125b88b15/scripts/taco_to_burrito.py#L278-L282

I guess it was not handled properly in the rust xml parser. That parser is going away soon anyways and we are handling it properly in the new one.