AsherGlick / ResourceCalculator

A Video Game Resource Calculator
https://resourcecalculator.com
GNU General Public License v3.0
59 stars 34 forks source link

Missing resources prevent proper query parameter interpretation #106

Open mmodrow opened 1 year ago

mmodrow commented 1 year ago

I tried to use cherry wood for a minecraft build, which is still missing. As the first cherry item was in the 2nd place of the query parameters (link created with the litematica plugin), only the first parameter was interpreted and then the rest was cut off.

See: https://resourcecalculator.com/minecraft/#dirt=80&strippedcherrylog=61&cherryslab=21&redstonedust=12&cherrytrapdoor=10&hopper=3&redstonecomparator=2&stickypiston=2&waterbucket=2&barrel=1&blockofredstone=1 (RaysWorks sniffer farm)

AsherGlick commented 1 year ago

Looks like we just dont gracefully handle malformed elements of the URI. We can skip over invalid elements, however they will still be stripped when the URI is next updated because it will be rebuilt from the internal state.

Screenshot from 2023-08-18 08-55-32

mmodrow commented 1 year ago

That would certainly be preferable over building a farm from 80 dirt only XD

AsherGlick commented 1 year ago

It is a dirt farm