AsherGlick
commented
4 months ago It will take me a bit to read through this. Some of the changes I think are great, such as the cutting ones where they produce more output then the equivalent crafting ones.
I'm not so sure about the fuel change. Most people will use coal or charcoal for their fuel, if you want to use bamboo that is fine you can just swap the recipe just for your own calculations without changing the global default for people without bamboo farms filling their smelters.
Oxidized Cut Copper Stairs is another weird one, but one that I might just be wrong about. Do people normally craft everything out of copper and then let it sit and oxidize, or oxidize everything an then craft what they want out of it.
While skimming I also noticed a change to firework rockets to make the 1-gunpowder version the default. I had originally made the 3-gunpowder version default because that is what most people wanted to craft for use with an Elytra. The bigger rockets made you travel farther.
It would probably help me to go through the changes faster if you were willing to take a bit of time and make comments in github for each group of changes indicating "why" that change was made. Just by clicking the + sign when hovering over a line in the "files changed" tab of this PR. Even something as simple as "cutting gives more output" would be super useful to help me understand the reason you want some or all of these changes.
Jackuhlf
I don't know much about coding, but I have reorganized some recipes so that the most used or easiest to obtain items are at the top. I have classified some blocks, such as Terracotta and Colored Wools, as raw resources because, even though they can be created from raw materials, it is easier to obtain them this way. I also prefer cutting over crafting, as it requires fewer resources. For example, 4 Copper Blocks can be crafted into 4 Cut Copper Blocks, but 1 Copper Block can be cut into 4 Cut Copper Blocks, reducing the amount of copper required by 75%.
Additionally, I treat fuel as a raw resource and suggest changes to how fuel is managed. Instead of saying you use N coal as fuel, it should specify that you need fuel to smelt N items, which corresponds to X coal or Y bamboo. This helps differentiate the coal required for building from the coal needed for fuel. I was confused as to why I needed over 1,000 coal when I only needed to make a few torches and campfires. I also had a bamboo farm for fuel, so there was no need for me to include fuel in the equation.