search

AsherGlick / ResourceCalculator

A Video Game Resource Calculator
https://resourcecalculator.com
GNU General Public License v3.0
57 stars 32 forks source link

Fixes lack of using custom_simplename in the hover recipe menu #67

Closed vreelb closed 2 years ago

vreelb commented 2 years ago

We were only sending recipes to the frontend so simplename was only used in templates prior to this. We now send a dictionary mapping name -> simplename that can be used for this (and possible other things later on).

Also fixes some typos and inconsistent space/tabs in files that were being edited.

Fixes #65

vreelb commented 2 years ago

If we want to really limit the data sent this could be optimized further by only sending overridden simple names and letting the frontend derive the rest from the full names (as it was doing with everything prior to this fix).

AsherGlick commented 2 years ago

I think sending over only the custom simple names is fine, though maybe this is a good chance to revisit the concept entirely. I have been looking at new ways to handle the calculator data and this might be something that gets swept up into that change. Specifically looking at changing the format of data sent to the front end. I can see a possible future where custom simple names are just suffixes on the base name, instead of full strings.

vreelb commented 2 years ago

Closing in favor of https://github.com/AsherGlick/ResourceCalculator/pull/72