AshesOfOwls / jquery.shapeshift

A dynamic grid system with drag and drop functionality.
http://ashesofowls.github.com/jquery.shapeshift/
MIT License
1.67k stars 311 forks source link

Determine the active children on render #52

Closed unindented closed 11 years ago

unindented commented 11 years ago

If I apply shapeshift to a container with children, then remove some of its children and add new ones, and trigger a ss-rearrange on the container, I expect the new children to be shapeshifted correctly.

However, triggering ss-rearrange calls render, which currently does not recalculate the children of the container, so the new nodes are not taken into account.

My solution involves calling setActiveChildren on render if reparse is true, which activates and parses new children, and makes everything work, but I'd like to hear your opinion on the performance implications of this.

AshesOfOwls commented 11 years ago

Looks good to me, thanks!