search

Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.09k stars 201 forks source link

Introduce a mechanism to sort feed groups #535

Open mbestavros opened 10 months ago

mbestavros commented 10 months ago

1. Environment

2. Describe the bug

In various contexts, across both Fever and GReader APIs, feed groups are often sorted strangely, without following any consistent logic.

For example: when a new group/category is created on the remote Fever server, Read You fetches the new group just fine, but always puts it at the end of the group list - no matter the alphabetical order.

For example, let's say I have the following groups:

Group 1
Group 2

Let's say I create Group 0 on the remote Fever server. After sync, I would expect the group listing to look like this:

Group 0
Group 1
Group 2

Instead, it looks like this at present:

Group 1
Group 2
Group 0

If we had manual group ordering, this would be less of a problem, but since that would be a bigger feature, it would be good to at least sort it alphabetically for now.

This also applies to the GReader API; it does not sort groups at all, and it's hard to control the order.

mbestavros commented 10 months ago

@kid1412621 - might be of interest to you since you were fiddling with groups in #526 and #531.

Ashinch commented 10 months ago

I believe it would be beneficial to introduce a new 'order' field to store the order on the remote server (if the API provides such information). This field can also be utilized to implement sorting for groups or feeds within the local account.

This feature is expected to be released with the GoogleReader API integration, or one release later.

kid1412621 commented 10 months ago

Hi guys, sorry for the delay. Ironically, I got a severe fever.😅 I'll check once getting better.

mbestavros commented 9 months ago

@Ashinch I've been testing the preliminary 0.9.12 release with GReader as my API recently and Miniflux as my backend. It's been working well, especially after the incremental sync refactor.

The one major issue I've noticed is that groups have a completely random ordering. Fever appeared to at least order groups alphabetically on first sync, but that doesn't appear to happen with GReader. This means that groups I care the least about (e.g. app updates) are put above things I care about a lot (the news).

You suggested implementing a manual group reordering feature as a fix earlier. While I support that as a complete solution, I'd suggest that we at least implement default alphabetical sorting for now, as a band-aid - especially if we don't want to implement manual ordering until a later release.

Also, since this issue has expanded from what I originally described, I'm going to edit it to be more descriptive.

Ashinch commented 9 months ago

The one major issue I've noticed is that groups have a completely random ordering. Fever appeared to at least order groups alphabetically on first sync, but that doesn't appear to happen with GReader. This means that groups I care the least about (e.g. app updates) are put above things I care about a lot (the news).

Hi, @mbestavros

I will check it.