search

Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.12k stars 202 forks source link

fix(ui): fix performance & data loading issues with sticky headers disabled #642

Closed JunkFood02 closed 5 months ago

JunkFood02 commented 8 months ago

About this PR:

Related issues: https://issuetracker.google.com/u/1/issues/193785330 https://stackoverflow.com/questions/67649953/sticky-headers-with-paging-library-in-jetpack-compose

mbestavros commented 6 months ago

@Ashinch @JunkFood02 Any reason this can't be merged?

JunkFood02 commented 5 months ago

Any reason this can't be merged?

The performance regression is not quite noticable with limited items (50 items per page currently). The issue of current implementation is that the app won't load new pages correctly because of the usage of peek instead of get. Since not many users have reported this issue yet, we've chosen to leave sticky headers enabled for now.