search

Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.12k stars 202 forks source link

Fix mark all as read on Fever API via Miniflux #699

Closed mbestavros closed 6 months ago

mbestavros commented 6 months ago

As detailed in #599, Read You's "Mark All As Read" button doesn't work when connected to Miniflux via the Fever API.

It turns out the fix is pretty simple: before, Read You was sending a before: timestamp of Long.MAX_VALUE. This produced a truly enormous epoch value, and it's possible Miniflux was just not interpreting it properly.

Changing the value to the current Unix time fixes the issue on Miniflux, and should remain functional for all other backends too. (It also just makes more logical sense.)

Tagging @Ashinch @JunkFood02 for review.

Ashinch commented 6 months ago

There could be future articles in the feed, and perhaps this method won’t be able to mark them as read.

mbestavros commented 6 months ago

@Ashinch I realized that this morning :sweat_smile:

Closing and following up on the linked issue.