search

Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.11k stars 202 forks source link

Add buttons to collapse and expand every group. #761

Closed aualbert closed 4 months ago

aualbert commented 5 months ago

Closes https://github.com/Ashinch/ReadYou/issues/760 (partially).

![Screenshot_20240612_163246](https://github.com/Ashinch/ReadYou/assets/116089283/9b41c655-b34e-4632-93d8-25013507bab5)
Ashinch commented 5 months ago

Hi, @aualbert

Thank you so much for your contributions. I will review them recently, but I‘m not sure if all of them can be merged.

aualbert commented 5 months ago

Hi, @aualbert

Thank you so much for your contributions. I will review them recently, but I‘m not sure if all of them can be merged.

Take your time! I'm open to debating the implementations. I personally feel like all of the these changes are minor and desired by the community.

Ashinch commented 5 months ago

Hi, @aualbert

I think we should follow the original UI and use only a single collapse/expand toggle button and keeping them aligned.

image
aualbert commented 5 months ago

Hi, @aualbert

I think we should follow the original UI and use only a single collapse/expand toggle button and keeping them aligned.

image

Sure!

aualbert commented 5 months ago

I we only keep one button, what should be its behavior if half of the groups are expanded ? This seems a bit strange to me. Perhaps https://github.com/Ashinch/ReadYou/issues/54 is the way to go.

Ashinch commented 4 months ago

I pushed some changes to https://github.com/aualbert/ReadYou/pull/1