Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.11k stars 202 forks source link

ci: Enforce unit tests on every pull request #784

Closed brenoepics closed 4 months ago

brenoepics commented 4 months ago

Related to #783

Adds a new GitHub Actions workflow to enforce unit tests on every pull request to the main branch.

brenoepics commented 4 months ago

@Ashinch : Each pull request should include sufficient unit tests covering new and modified code.

This would be a little more complicated, I can't do it in an action without some external action/plugin, I think it's better to discuss this, have you considered SonarCloud, CodeCov or Qodana...? They have free options for open source projects.

example from another repository of mine: image

Or just checking that the tests didn't fail is ok?

Ashinch commented 4 months ago

Hi, @brenoepics

Thank you for your work on this! For now, we just need to ensure that the unit tests are executed. I am currently working on increasing the test coverage of our infrastructure. “Sufficient unit tests covering” is more of an expectation rather than a mandatory requirement at the moment.